If we render a component, then rerender it with different defaultPageIndex and pageCount, we can see values like Page -2, Page -1, Page 0. The defaultPageIndex is also not respected when this value is updated.

Changes here:

• Update playground so we can see pager, set page size, and default index
• Component state only uses initial state on first render. To detect when defaults change, I use more component state to store initial state, and trigger related events when we detect these values have changed. An example would be updating defaultIndex
• I also expanded test coverage to catch these rerender cases.

Feel free to suggest alternatives, if folks can think of anything cleaner.

While testing I found an odd corner case for truncation. This is also present in main. I fixed this by doing a bounds check when setting offset.

before	after

Closes https://github.com/github/meao/issues/2720

Changelog

New

Changed

Removed

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)